search

mhulse / kludgy

Kludgy: A macOS Node.js module/app that generates a random Google Street View desktop wallpaper.
Apache License 2.0
4 stars 2 forks source link

...... 2> /dev/null #20

Closed mhulse closed 5 years ago

mhulse commented 7 years ago

Got this today when entering in an invalid Google Maps Key:

$ kludgy "xxxxxxxxx"
Invalid TAG name: 6.395677543337092
Invalid TAG name: 6.395677543337092
Invalid TAG name: 6.395677543337092
Warning: Can't convert GPS:GPSLatitudeRef (not in PrintConv)
Ignored superfluous tag names or invalid options: -6.395677543337092 ...
Error: File not found - Maps
Error: File not found - API
Error: File not found - error:
Error: File not found - InvalidKeyMapError
Error: File not found - https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key-map-error
Error: File not found - Google
Error: File not found - Maps
Error: File not found - API
Error: File not found - error:
Error: File not found - InvalidKeyMapError
Error: File not found - https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key-map-error
Error: File not found - Maps
Error: File not found - API
Error: File not found - error:
Error: File not found - InvalidKeyMapError
Error: File not found - https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key-map-error
Error: File not found - Google
Error: File not found - Maps
Error: File not found - API
Error: File not found - error:
Error: File not found - InvalidKeyMapError
Error: File not found - https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key-map-error
Error: File not found - Maps
Error: File not found - API
Error: File not found - error:
Error: File not found - InvalidKeyMapError
Error: File not found - https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key-map-error
Error: File not found - Google
Error: File not found - Maps
Error: File not found - API
Error: File not found - error:
Error: File not found - InvalidKeyMapError
Error: File not found - https://developers.google.com/maps/documentation/javascript/error-messages#invalid-key-map-error

I think the "Invalid TAG name" was due to the output from the Google Maps HTML scraping (probably a console message that got output and passed to shell scripts).

Thinking if this happens more often, send the output to 2> /dev/null.

mhulse commented 5 years ago

OR, improve how things fail; be more graceful.

mhulse commented 5 years ago

Opted to refactor whole codebase and will be releasing v2.0.0 soon!

This issue only applies to v1, and I have no plans to improve the code for that codebase.

Closing.