search

mhulse / kludgy

Kludgy: A macOS Node.js module/app that generates a random Google Street View desktop wallpaper.
Apache License 2.0
4 stars 2 forks source link

Document that save location must be absolute #28

Closed mhulse closed 5 years ago

mhulse commented 7 years ago

I thought I implemented tilde expansion, but it looks like I did not.

Though, IIRC, I may have skipped tilde expansion for the sake of simplicity.

Either add tilde expansion for the image save location option or just make sure to document that the path to the save folder must be an absolute system path.

I think life would be easier to just document root path as the code has multiple entry points, not all of them are through node (which would make tilde expansion easy), so I'd rather not have to write code for each entry point (ok, it would just be node.js or shell, but still, seems like documenting root path is a requirement is best).

mhulse commented 5 years ago

v2 of the codebase does not have this issue. Though, I may need to test the new codebase when ran via CLI.

Either way, closing.