mhulse / kludgy

Kludgy: A macOS Node.js module/app that generates a random Google Street View desktop wallpaper.
Apache License 2.0
4 stars 2 forks source link

Why doesn't the returned Lat Lon not find street view? #34

Closed mhulse closed 5 years ago

mhulse commented 5 years ago

In kludgy.sh, I tried switching from ID to lat/long.

Just doesn't seem to work. I was hoping that would allow me to use any returned pano, vs just Google ones (see #4).

For example, if I remove the check for "Google" here:

https://github.com/mhulse/kludgy/blob/fa39840b0566a9b25b39e9fd8141657ccabb4cd8/kludgy.js#L50

And if you remove the first two args below, and replace with "lat,lon" (see docs for that lib):

https://github.com/mhulse/kludgy/blob/fa39840b0566a9b25b39e9fd8141657ccabb4cd8/kludgy.sh#L71-L78

Unfortunately, pano not found when doing this.

I suspect it's due to user panos. I need to test by keeping the "Google" check and seeing if it just doesn't like lat/lon in general. If so, then I might suspect it's due to precision in the numbers?

mhulse commented 5 years ago

The real issue was due to user panos. Official Google panos worked, but user panos did not due to different URLs used for the tile images.

This has been fixed/solved in v2 codebase.