mhulse / kludgy

Kludgy: A macOS Node.js module/app that generates a random Google Street View desktop wallpaper.
Apache License 2.0
4 stars 2 forks source link

Move this._levels into validate? #60

Open mhulse opened 5 years ago

mhulse commented 5 years ago

https://github.com/mhulse/kludgy/blob/b78e08ef632414ce8d2e07bfcd4d77ec6f1fdcbd/index.js#L21-L24

Doing so would make index.js a little more clean.

My original thought was that I'd use levels more; so far, just use it in validate().

Wondering if I can re-work the code to use it more? Maybe in all the debug lines for placeholder data? For example:

https://github.com/mhulse/kludgy/blob/b78e08ef632414ce8d2e07bfcd4d77ec6f1fdcbd/index.js#L150-L151

And, should that be >= 2? Assuming that future debug, >=3 build off the lesser debug levels.

Alternatively, stop using levels and include an option for debug (i.e. console.log()) and an options for placeholder data output. Doing this adds more API fiddly bits, but could help to simplify debug.