mhutch / MonoDevelop.MSBuildEditor

Improved MSBuild editing support
Other
228 stars 26 forks source link

PackageReference Condition warning #199

Open nietras opened 7 months ago

nietras commented 7 months ago

We often have to selective condition on package references especially native runtime packages like shown below. Hence, the warning is in that case not particularly relevant.

image

mhutch commented 7 months ago

Yes, the current implementation of this analyzer is very naive and will result in a lot of false positives. Fixing it properly will require property dependency tracking, which is some ways off. For now, I could change it to check for $(Configuration) only.

Once we have editorconfig and the ability to suppress individual analyzers I might consider re-enabling it in its current form, as I think "hey, this might be problematic, suppress if you're sure you know what you're doing" has some value.