XML autocomplete removes too much

mhutch / MonoDevelop.MSBuildEditor

Improved MSBuild editing support

Other

211 stars 24 forks source link

XML autocomplete removes too much #220

Closed KirillOsenkov closed 2 months ago

KirillOsenkov commented 2 months ago

Hit Ctrl+Space and pick the folder from menu:

Press enter. Expected: first image. Actual:

@miloush

mhutch commented 2 months ago

Is this with main? I can't find the commit but I feel like I fixed something related to this recently.

KirillOsenkov commented 2 months ago

No, we will update to latest and retest

KirillOsenkov commented 2 months ago

I can confirm this is now fixed.

However if the caret is not at the end of the word, it completes the remainder of the word (unlike C#):

Not sure if this is the desired behavior.

Maybe if there's a single completion, and the word in the editor around the trigger point matches the completion exactly, the completion shouldn't show but the caret should move to the end of the word? This is how C# works.

KirillOsenkov commented 2 months ago

In any event, this perhaps should be opened in a new bug, since the original repro scenario is now fixed.

KirillOsenkov commented 2 months ago

Filed #227 and closing this one.