search

mhutch / MonoDevelop.MSBuildEditor

Improved MSBuild editing support
Other
228 stars 26 forks source link

`PrivateAssets` and `IncludeAssets` are showing warnings as unknown #233

Closed HakamFostok closed 1 month ago

HakamFostok commented 6 months ago

In the Directory.Packages.props file, I have a the following

image

image

In both cases PackageVersion and GlobalPackageReference the PrivateAssets and IncludeAssets are showing a yellow underline and the following warning

image

Note: I would like to help in solving this if provided with proper guidance, I already contributed to this amazing project and I would love to do that again, if I can

Thank you ver much

mhutch commented 6 months ago

Hi! The correct fix would be to add GlobalPackageReference to the list of items these metadata apply to: https://github.com/mhutch/MonoDevelop.MSBuildEditor/blob/d95cfbc8e5b6f6a499f8956a6f6a2394db02abfe/MonoDevelop.MSBuild/Schemas/CommonTargets.buildschema.json#L985

mhutch commented 1 month ago

Closing as these metadata are ignored per the comment in the PR thread