search

mhutchie / vscode-git-graph

View a Git Graph of your repository in Visual Studio Code, and easily perform Git actions from the graph.
https://marketplace.visualstudio.com/items?itemName=mhutchie.git-graph
Other
2.02k stars 269 forks source link

Include built-in support for several new emoji shortcodes recently added to gitmoji #316

Closed TobiasTao closed 4 years ago

TobiasTao commented 4 years ago

Describe the Bug emoji wastebasket is not displayed correctly image

Expected Behaviour show： 🗑️ Environment

mhutchie commented 4 years ago

Hi @TobiasTao,

Git Graph has built-in support for many emoji shortcodes, including all of gitmoji and some other common shortcodes. As there are almost endless shortcodes and different flavours used around the world, I had to decide on a built-in set of the most common (:wastebasket: isn't one of them).

However, when I implemented emoji shortcode replacement, I also created a new Extension Setting Custom Emoji Shortcode Mappings that allows users (like yourself) to define any other emoji's they use (that aren't built-in).

You will be able to use the above mentioned Extension Setting to define a custom mapping for :wastebasket: to your desired emoji.

I'll close this issue as it is not a bug, and this functionality is already provided in Git Graph.

TobiasTao commented 4 years ago

Thanks you for your reply @mhutchie, but gitmoji already contains :wastebasket: image maybe you should update.

mhutchie commented 4 years ago

Hi @TobiasTao,

Thanks for making me aware of that. Since Gitmoji has recently added :wastebasket: (after I added Gitmoji support), I’ll update the built-in list in Git Graph to include it and any other new emojis they’ve recently added.

mhutchie commented 4 years ago

This will be available in v1.24.0.

If you'd like to use it before the next release, you can download v1.24.0-beta.1, and install it following the instructions provided here.

ADIX7 commented 4 years ago

@mhutchie On https://gitmoji.carloscuesta.me/ the documentation icon is now :memo: while in your extension it is :pencil:. Has it been renamed on the site?

mhutchie commented 4 years ago

Hi @ADIX7,

I've just compared the set of short-codes I last imported from gitmoji into Git Graph, to the latest set of gitmoji. In the last five months, gitmoji have made the following changes:

I'll apply these changes in the next release of Git Graph, and reply to this thread with a link to a beta release with these changes within the next week.

I've included importing gitmoji into my pre-release steps, so that going forward the set of gitmoji in Git Graph is always kept in sync.

ADIX7 commented 4 years ago

Sounds great, thank you for the fast response!

mhutchie commented 4 years ago

Hi @ADIX7,

The delivery of the built-in support for the new Gitmoji was tracked by #409. Please see my closure comment on it for a link to the beta release, and instructions for how to install it.