mhutchie / vscode-git-graph

View a Git Graph of your repository in Visual Studio Code, and easily perform Git actions from the graph.
https://marketplace.visualstudio.com/items?itemName=mhutchie.git-graph
Other
2.03k stars 271 forks source link

Display the status of GH Actions Checks #462

Open williamluke4 opened 3 years ago

williamluke4 commented 3 years ago

Example

image

mhutchie commented 3 years ago

Hi @williamluke4,

Thanks for raising this feature request, this would definitely be great to have in Git Graph!

The only hesitation I have is that this is a vendor specific capability, which can only be used by the portion of the extensions users that use public GitHub repositories and GitHub actions. One of the biggest factors I use when prioritising the implementation of features is the number of users will get value from the feature, so anything vendor specific is generally lower on the list. Additionally, once I implement one vendor specific feature, almost certainly many others will follow for a variety of different vendors - leading to a lot of code sitting unused for every user (currently the extension is very lean).

The only exception I’ve currently made to this rule is for commit author avatars, as it is a broad capability available by most vendors, and it was fairly reasonable to support the most common vendors (so a large portion of users were able to use it). In saying that, avatars have been extremely painful to deal with in the long term.

I’ll see how much user interest there is for this feature. If enough users would value this feature, I’ll happily implement it.

FYI: I included the above vendor comments just to make people aware that it is something I have to consider (most users overlook it). As long as there’s enough users who indicate they will value a feature, I’ll implement it regardless of whether it's vendor neutral or vendor specific.

keydepth commented 3 years ago

Hello! @mhutchie and @williamluke4 ,

Every day I use Git Graph extention. This is very confourtable git extention for my software developnment. I'd like to upgrade for this issue. Please assign to me this issue.

I'v checked vendor specific automation API. GitHub Actions has workflow-jobs API, GitLab has Pipeline API and Jenkins has Build Status.

GitHub Actions has workflow-jobs API

GitLab Pipeline API

Jenkins Build Status API

I need pipeline status, so I'm going to develop column of GitLab Pipeline Status, like this below.

image

"success" is pipeline status and link to action details. Frontend is under conftruction..

We need GitLab Pipeline setting is in "Repository Settings"

There are Add / Edit / Remove settings.

image

This is detail of setting dialog.

image

mhutchie commented 3 years ago

Hi @keydepth,

Thanks for your work so far, that’s definitely some great progress!

Once you get to a releasable solution, please raise a PR so I can try it out, review your implementation, and give feedback.

keydepth commented 3 years ago

Hello! @mhutchie,

I've implemented Pipeline/Workflow status for GitLab/GitHub. It's just preview commit. I'll change this feature name "Pipeline Status" to "CI/CD Status", because "Pipeline" is only in the GitLab.