Closed DerXanRam closed 10 months ago
Thank you for the PR! We defenitely need some built-in functions to interact with RPCs. But, since it's a C library, we should keep the code in C language. And, also, all the new functions must follow some rules (like each public function should start with the eth_
prefix and header files should go in the include/ethc
folder etc.) to keep the API of the library stable.
Using external libraries for serializing/deserializing JSON data? I don't know. I think it's better to make our own to keep the library as dependency free as possible. For making http calls, it's totally fine to use CURL.
So, I can't merge this PR right now, but it stays open. Again, thanks for the PR!
Thank you for the PR! We defenitely need some built-in functions to interact with RPCs. But, since it's a C library, we should keep the code in C language. And, also, all the new functions must follow some rules (like each public function should start with the
eth_
prefix and header files should go in theinclude/ethc
folder etc.) to keep the API of the library stable.Using external libraries for serializing/deserializing JSON data? I don't know. I think it's better to make our own to keep the library as dependency free as possible. For making http calls, it's totally fine to use CURL.
So, I can't merge this PR right now, but it stays open. Again, thanks for the PR!
Hello bro...thanks for revising the PR. As u saied, the header i write have some dependencies on external json parser and curl. Also it is c++. It is very stable and it may use as a reference for the future if u want to include this feature. I am not very good at C but i will try to make a C version of this. Tnx bro :pray:
Of course, I'll take inspirations from this PR. It's a great feature to have.
Of course, I'll take inspirations from this PR. It's a great feature to have.
ok bro :+1: .....i will code the header to fit the standard u specified. And also i was using nlohmann to parse previously. So to switch to this lib and make everything fit, it needs some time.... i will PR as soon as i finished it.
Have a nice day bro :+1:
Any progress on this?
Any progress on this?
yes. But little straggle to fit in to the architecture u provided. The rest is progressing in good way :+1: .
Hey bro. How are u. I'm not online this two day due to some personal problems. I think i will back tomorrow. Soryy for late🙏
Hey @DerXanRam . No worries, you don't have to.
Hey @DerXanRam . No worries, you don't have to.
Hello mate. I'm back after 6 Hard days. How was everything?
Hey @DerXanRam If you don't have free time to work on this, I'll merge the dev branch.
Hey @DerXanRam If you don't have free time to work on this, I'll merge the dev branch.
Hello mate. do u mean integrating the mpint
integration now to main branch?
@DerXanRam Yes, there are some other changes as well in that branch. I'll merge the dev
branch and bump the version. This feature will be in the next versions (1.2.0?)
@DerXanRam Yes, there are some other changes as well in that branch. I'll merge the
dev
branch and bump the version. This feature will be in the next versions (1.2.0?)
ok mate..... merg it and i will PR when i finished it :+1:
Created feat-rpc
branch for this feature.
Closing the PR: https://github.com/mhw0/libethc/pull/28#issuecomment-1721092608
we can use this header like this in main.cpp
This header is tested againist infura.io and blastapi.io.
This headers and libraries are must be included to compile