mhw0 / libethc

Open-source Ethereum C library
https://mhw0.github.io/libethc/
MIT License
46 stars 8 forks source link

ci: run unit tests on every branch #18

Closed mhw0 closed 11 months ago

DerXanRam commented 11 months ago

i'm on it bro :+1:

mhw0 commented 11 months ago

I think it's in this file: .github/workflows/ci-unix.yaml

DerXanRam commented 11 months ago

I think it's in this file: .github/workflows/ci-unix.yaml

i thought u say running unit test on dev branch cause u added uint data type for rpl and i was testing it. Can u tell me briefly what type of test u want to say? i think i missed your point.

mhw0 commented 11 months ago

i thought u say running unit test on dev branch cause u added uint data type for rpl and i was testing it. Can u tell me briefly what type of test u want to say? i think i missed your point.

Currently, tests are configured to run only on the main branch meaning that if you push changes to any other branch, you can't see if the tests passed or not.

dev branch:

Screenshot 2023-08-24 at 23 21 36
DerXanRam commented 11 months ago

ok... so i must wait until it u merge it?

mhw0 commented 11 months ago

ok... so i must wait until it u merge it?

Fixed it in a9e34baeb3800134ab32967e4b58255b8c082e81. Closing the issue.

DerXanRam commented 11 months ago

ok... so i must wait until it u merge it?

Fixed it in a9e34baeb3800134ab32967e4b58255b8c082e81. Closing the issue.

Now i can test . Right?

mhw0 commented 11 months ago

Now i can test . Right?

test what? new functionality?

DerXanRam commented 11 months ago

Now i can test . Right?

test what? new functionality?

uint in rpl

DerXanRam commented 11 months ago

Now i can test . Right?

test what? new functionality?

uint in rpl

I saw u deployed it in dev

mhw0 commented 11 months ago

I saw u deployed it in dev

Yes, you can use it.

DerXanRam commented 11 months ago

I saw u deployed it in dev

Yes, you can use it.

Ok 👍

DerXanRam commented 11 months ago

uint worked without a problem :+1: ... tnx for this amazing library :pray: