mhx / dwarfs

A fast high compression read-only file system for Linux, Windows and macOS
GNU General Public License v3.0
2.16k stars 58 forks source link

dwarfsextract still occasionally prints garbage to console #143

Closed galtgendo closed 1 year ago

galtgendo commented 1 year ago

So, for the first time since the previous report I've had to use dwarfsextract again. I seem to keep running into some tricky files, cause once again I see garbage in console.

I'm not 100% percent sure if I nailed down the problem, but AFAICT it seems quite straightforward: in src/dwarfs/filesystem_extractor.cpp in close() you're calling check_result on the return of archive_write_free. The catch is that check_result uses resources that archive_write_free will free, so the check (depending on timing) may give bogus results - for me that happens on every run (AFAICT).

galtgendo commented 1 year ago

Sorry, I was still using old sources, this has already been fixed in 0e44a8b7fa4f1ddae60e8251adb5d858.