Develop

[cebarboza]

Hello,

• Checks are implemented for TrainExplore.
• I am doing the main checks first, since you call settingsExplore from there.
• I commented ClassFeature, PositiveClass, FeatureInclude, Maximize, Accuracy, Specificity, since I have problems running the tests with the default values we discussed. But it is just matter to define the correct ones.

[AniekMarkus]

ClassFeature, PositiveClass -> should always be given by the user, do not use a default value (we need to check the strings with/without '', so that the code can still run even if these are included in the column names) FeatureInclude -> default is now "" -> this should be a valid option, does an empty string not pass the test? is there another way in which the user can decide not to use this functionality? Maximize -> this seems to be working? Accuracy, Specificity -> default values can be set to 0 values

[cebarboza]

Hey!

FeatureInclude is working with an empty string. For now I can only imagine we can set that to NULL, and later convert that to “”, but if the empty string is the default, there’s not much difference.

I made those corrections and the tests passed. I am working now on making sure it passes most Github Actions and eliminate the warnings. Let’s see if I can finish that soon, at least by the end of this week.

I hope you are having a productive summer school!

Cheers.

From: AniekMarkus @.> Sent: Thursday, June 15, 2023 1:00 PM To: mi-erasmusmc/Explore @.> Cc: Cesar Barboza Gutierrez @.>; Author @.> Subject: Re: [mi-erasmusmc/Explore] Develop (PR #9)

Waarschuwing: Deze e-mail is afkomstig van buiten de organisatie. Klik niet op links en open geen bijlagen, tenzij u de afzender herkent en weet dat de inhoud veilig is. Caution: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

ClassFeature, PositiveClass -> should always be given by the user, do not use a default value (we need to check the strings with/without '', so that the code can still run even if these are included in the column names) FeatureInclude -> default is now "" -> this should be a valid option, does an empty string not pass the test? is there another way in which the user can decide not to use this functionality? Maximize -> this seems to be working? Accuracy, Specificity -> default values can be set to 0 values

— Reply to this email directly, view it on GitHubhttps://github.com/mi-erasmusmc/Explore/pull/9#issuecomment-1592830177, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3AZW5VPESCWJZXEKUVLDCLXLLTK7ANCNFSM6AAAAAAZHOVC4U. You are receiving this because you authored the thread.Message ID: @.***>

[cebarboza]

On this PR, R CMD Check is passing without errors. We still have a Warning pending.

[cebarboza]

@AniekMarkus I also added a new rule in which we need an approval before merging to main.