search

mi-schi / phpmd-extension

Contains extra phpmd rules from clean code book and the best practices of my experiences.
MIT License
39 stars 7 forks source link

Controller Action Naming #9

Closed samnela closed 6 years ago

samnela commented 6 years ago

Don't add the Action suffix to the methods of the controller actions.This suffix became optional when annotations were introduced for controllers. In modern Symfony applications this suffix is neither required nor recommended .

mi-schi commented 6 years ago

Okay thanks for the information. I'll try to remove it.

Do you have a reference?

mi-schi commented 6 years ago

Okay, I find the reference: The "Action" suffix was removed in the documention for Symfony 4.0: https://symfony.com/doc/4.0/controller.html In the documentation for Symfony 3.3 the "Action" suffix is defined: https://symfony.com/doc/3.3/controller.html

mi-schi commented 6 years ago

I create a new version 4.3.0

samnela commented 6 years ago

Sorry for the delay, my reference is Symfony best practices : http://symfony.com/doc/current/best_practices/controllers.html#controller-action-naming thank you @mi-schi for this one .

mi-schi commented 6 years ago

Thx. I created a new version yesterday :) Feel free to update ;)