search

mi2-warsaw / FSelectorRcpp

Rcpp (free of Java/Weka) implementation of FSelector entropy-based feature selection algorithms with a sparse matrix support
http://mi2-warsaw.github.io/FSelectorRcpp/
35 stars 15 forks source link

Discretize - arguments #46

Closed AleksandraDabrowska closed 7 years ago

AleksandraDabrowska commented 7 years ago

discretize(x = iris[[1]], y = iris[[5]],k=2) - unused argument k , but there is no warning

discretize(x = iris[[1]], y = iris[[5]], control = list(equalsizeControl(k = -1)), keepAll = TRUE, call = NULL) -for k smaller than zero or non-integer we should get error (R encountered a fatal error)

MarcinKosinski commented 7 years ago

I have added special stopifnot condition to the equalsizeControl about k. I have renamed keepAll to all and extended it's documentation to be more clear. Thanks for suggestions.

I can not fix anyway the issue with no warning when you pass unneeded parameters as this is the deep Rcpp dependency issue :)