Closed twolodzko closed 7 years ago
The idea Here is to provide as much compatibility with the original FSelector output as possible, since FSelectorRcpp is just rewritten and updated other package, called FSelector.
But addding additional column might not be such a bad idea. @zzawadz what do you think?
Notice that using rownames to pass on additional information about data is rather discouraged by many authors. Moreover, transforming the information.gain() output to other objects, e.g. dplyr's tibble, could possibly lead to dropping the rownames.
Good point. I think that we shouldn't sacrifice usability for backward compatibility.
@twolodzko You're just in time.We are planning to submit our package to CRAN tomorrow;) But I think it will contain that feature:)
@MarcinKosinski @twolodzko can you play a bit with the new version?
I might prepare a new blog post about the release and play with some code. Does cut_attrs() know right now that the information_gain gives different result?
Marcin Kosinski
Dnia 04.03.2017 o godz. 08:50 Zygmunt Zawadzki notifications@github.com napisał(a):
@MarcinKosinski @twolodzko can you play a bit with the new version?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@MarcinKosinski @zzawadz I'll play around and let you know if I have any further comments.
information_gain()
returns single-column data.frame with importance scores:This output is however not very friendly since names of the variables are provided as rownames. Instead they should rather be provided as additional column with their names. This would make them easier accessible from other functions.
Notice that using rownames to pass on additional information about data is rather discouraged by many authors. Moreover, transforming the
information.gain()
output to other objects, e.g. dplyr's tibble, could possibly lead to dropping the rownames.