search

mi6 / ic-design-system

Intelligence Community Design System
https://design.sis.gov.uk
MIT License
43 stars 30 forks source link

For each orgs icon in the footer, each footerLink there is a "listitem" and the parent element (the logo-wrapper) doesn't have role "list" #1174

Open mi6-378 opened 1 month ago

mi6-378 commented 1 month ago

Summary of the bug

After exploring the ICDS page accessibility, there appears to be an issue regarding the icons in the footer.

🪜 How to reproduce

Using the 'accessibility insights for web' chrome extension and testing the tabular format of any other the pages returns an issue regarding aria labels.

This is also visible in the automated checks part of this extension.

The process to fix is stated as: 'Required ARIA parent role not present: list'.

📸 Screenshots or code

Screenshot 2024-10-21 at 11 57 16

Automated checks: step 1 of 3

Screenshot 2024-10-21 at 11 57 59

What the errors look like on this page

Screenshot 2024-10-21 at 11 32 53

Section 2 of 3 with tabular perspective

🧐 Expected behaviour

I expected there to be no issue regarding these and the tabbing to return no errors.

GCHQ-Developer-299 commented 1 month ago

Followup task: https://github.com/mi6/ic-design-system/issues/1178