search

mi6 / ic-design-system

Intelligence Community Design System
https://design.sis.gov.uk
MIT License
43 stars 30 forks source link

[ic-select-with-multi] Code example mistake #1198

Open gd2910 opened 2 weeks ago

gd2910 commented 2 weeks ago

Summary of the bug

The top code demo for IcSelectWithMulti - Javascript doesn't contain an options array which breaks the example Copy the options from examples below to fix the issue

📸 Screenshots or code

Link to code example

otutukingsley commented 2 weeks ago

@gd2910 can you assign this issue to me? I would like to work on it.

GCHQ-Developer-112 commented 1 week ago

Done @otutukingsley 👍

otutukingsley commented 1 week ago

@gd2910 @GCHQ-Developer-112 which line am I adding the options array to? I assume we are to make this change in the code.mdx file which is in the src/content/structured/components/multi-select directory.

gd2910 commented 1 week ago

Hi @otutukingsley , you're adding the options array to line 108 in the multi-select code.mdx, above the return statement.

otutukingsley commented 1 week ago

@gd2910 I just created the PR for this issue, can you take a look when you have the time? Thank you!

otutukingsley commented 3 days ago

@gd2910 I just created a new PR for this issue, can you take a look when you have the time? Thank you!