search

mi6 / ic-design-system

Intelligence Community Design System
https://design.sis.gov.uk
MIT License
42 stars 29 forks source link

Incorrect code snippet for ic-dialog #648

Open GCHQ-Developer-741 opened 1 year ago

GCHQ-Developer-741 commented 1 year ago

Summary of the bug

The code snippet for ic-dialog, under the "Interactive Content" heading, the React example should include an onIcDialogConfirmed event listener.

🧐 Expected behaviour

<IcDialog ref={dialogEl} label="Coffee order"
  heading="Please agree to our terms and conditions"
  onIcDialogConfirmed={termsDialogConfirmed}
>
MI6-255 commented 3 months ago

Is this done @MI6-94 ?

MI6-94 commented 2 months ago

@MI6-255 did not complete, return to 'ready for dev'