search

mi6 / ic-ui-kit-test-app

MIT License
2 stars 1 forks source link

Improve testing #14

Open GCHQ-Developer-530 opened 3 months ago

GCHQ-Developer-530 commented 3 months ago

Summary

Now that the app has been extended by devs, the tests should be improved by a tester.

💬 Description

An example of where tests could be improved are for canary components e.g. date input/data table/date picker.

Do the current tests need splitting out into smaller tests? (e.g. Subscription tests are quite long) Should we add accessibility tests in Cypress like we do in our ic-ui-kit repo? Should we add visual snapshot tests in Cypress like we do in our ic-ui-kit repo? If we add visual snapshots, do we need to add high contrast/mobile tests as well? Do we need to add any other testing frameworks? (e.g. on our site we separate out Jest and React Testing Library, so do we need to add regular jest tests alongside our RTL ones?)

💰 Use value

Makes us more confident on our components in an app setting.

GCHQ-Developer-741 commented 2 months ago

Potentially split out between people to do different testing types

evenstensberg commented 3 weeks ago

I'd go for playwright for testing in this repo