search

mi6 / ic-ui-kit-test-app

MIT License
2 stars 1 forks source link

chore(root): add husky, nvm, bump deps and improve infra #29

Open evenstensberg opened 4 days ago

evenstensberg commented 4 days ago

Summary of the changes

Adds pre-commit hooks, bumps dependencies and adds nvm

Related issue

N/A

evenstensberg commented 4 days ago

PTAL. Most likely husky had some dependencies that couldn't be properly resolved in a container that uses node_modules in a particular way. Solved by adding the failing dep as an optional in package.json.

I've also bumped all the dependencies when I had the chance. The lockfile being false didn't work in the CI because the action running npm ci (which installs deps faster) needs a lockfile.