search

mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 23 forks source link

[ukic/react]: Add `types.ts` in `ukic/web-components` to `ukic/react` #1395

Open GCHQ-Developer-112 opened 5 months ago

GCHQ-Developer-112 commented 5 months ago

Summary & 💰 Use value

Currently, users needs to import the types.ts file from the @ukic/web-components package even if they are using the React components. Based on user feedback, adding the types.ts file to the React package will improve the developer experience. Alternatively, we can consider either making it clearer in our guidance that types should be imported from @ukic/web-components or creating a @types package.

The suggested action for this issue is a spike as well as applying the suggested change. The chosen change should also be applied to the @ukic/canary-react package.

MI6-255 commented 3 months ago

Discuss at time if we have a types package or not