search

mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 27 forks source link

Focus state in Cypress visual regression tests #1463

Open gd2910 opened 9 months ago

gd2910 commented 9 months ago

Summary of the bug

Some component visual regression tests where focus state is included needs padding added to ensure the entirety of the component and state is visible.

📸 Screenshots or code

Along with the following tests, IcAccordion focus state visual tests need adding. IcButton.cy.tsx-dropdown-popover.png IcSelect.cy.tsx-clear-button-cleared.png IcSelect.cy.tsx-custom-elements-open.png IcSelect.cy.tsx-custom-elements-open.png IcSelect.cy.tsx-default-open.png IcSelect.cy.tsx-default-value-open.png IcSelect.cy.tsx-descriptions-open.png IcSelect.cy.tsx-disabled-options-open.png IcSelect.cy.tsx-full-width-open.png IcSelect.cy.tsx-groups-open.png IcSelect.cy.tsx-recommended-open.png IcSelect.cy.tsx-small-deprecated-open.png IcSelect.cy.tsx-small-open.png IcSelectSearchable.cy.tsx-searchable-custom-elements-open.png IcSelectSearchable.cy.tsx-searchable-default-open.png IcSelectSearchable.cy.tsx-searchable-default-value-open.png IcSelectSearchable.cy.tsx-searchable-descriptions-in-filter-open.png IcSelectSearchable.cy.tsx-searchable-descriptions-open.png IcSelectSearchable.cy.tsx-searchable-disabled-options-open.png IcSelectSearchable.cy.tsx-searchable-full-width-open.png IcSelectSearchable.cy.tsx-searchable-groups-in-filter-open.png IcSelectSearchable.cy.tsx-searchable-groups-open.png IcSelectSearchable.cy.tsx-searchable-recommended-open.png IcSelectSearchable.cy.tsx-searchable-search-match-position-open.png IcSelectSearchable.cy.tsx-searchable-small-open.png IcSelectSearchable.cy.tsx-searchable-small-open-deprecated.png

🧐 Expected behaviour

Visual test should encapsulate the full component, focused and not.

📝 Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given When
Then

Additional info

Tell us anything else useful to help us fix or understand the problem.

gd2910 commented 9 months ago

In addition, the IcTopNavigation visual tests with slotted navigation contain a scroll bar, this will need removing.

MI6-255 commented 7 months ago

Explore if this can be repeatable and turned off for anything like Top Navigation