mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 27 forks source link

Add adornment ​to text field #1635

Open skennedy100 opened 8 months ago

skennedy100 commented 8 months ago

Summary

I implemented a upload dialogue box recently in which I use a text field for the filename, I was surprised to find out that there is no adornment and therefore had to add a label after the text box, make it flex so they're on the same line, then handle the validation state being set on the text box causing the label to anchor to the bottom.

πŸ’¬ Description

Adornments are pretty standard in text fields, see material UI for full details

πŸ’° Use value

Reveal/hide password, additional context in fields for weight, money, file type, etc.

πŸ“ Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given a user has chosen to upload a file When the file is selected Then the text box is capable of displaying the file extension

✏ Designs

From material UI: image

β€―πŸ§Ύ Guidance

https://mui.com/material-ui/react-text-field/

Additional info

Tell us anything else useful to help us understand your suggestion.

github-actions[bot] commented 8 months ago

Welcome πŸ‘‹

Welcome to the ic-design-system repo, thank you for raising an issue!

How to contribute

Please read our CONTRIBUTING.md, which explains our ways of working and guidelines for contributions.

Code of Conduct

We'd appreciate it if you could read and abide by our Code of Conduct, as we wish to foster an inclusive and respectful community.

github-actions[bot] commented 8 months ago

Welcome πŸ‘‹

Welcome to the ic-ui-kit repo, thank you for raising an issue!

How to contribute

Please read our CONTRIBUTING.md, which explains our ways of working and guidelines for contributions.

Code of Conduct

We'd appreciate it if you could read and abide by our Code of Conduct, as we wish to foster an inclusive and respectful community.