search

mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 25 forks source link

[ic-typography] accessibility error on see more/see less button #1854

Open GCHQ-Developer-530 opened 5 months ago

GCHQ-Developer-530 commented 5 months ago

Summary of the bug

When running accessibility tests using accessibility insights and the storybook a11y add on, the same error occurs.

aria-hidden-focus - ensure aria-hidden components aren’t focusable.

This is because the see more/see less typography button is focusable and aria-hidden

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to truncation example on storybook
  2. Click on the accessibility tab in storybook or run an accessibility insights fast pass
  3. See the error

🧐 Expected behaviour

It shouldn't produce this accessibility error.

MI6-255 commented 4 months ago

Why do we aria hide this link?

MI6-286 commented 3 months ago

When fixed, uncomment the a11y tests in the ic-typography Cypress tests.

evenstensberg commented 3 months ago

Can I fix this?