search

mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 23 forks source link

[ic-accordion] accordion sizes don't match Figma designs #1856

Open GCHQ-Developer-530 opened 1 month ago

GCHQ-Developer-530 commented 1 month ago

Summary of the bug

In the Figma designs, the different size variations have an impact on the width of the accordion as well. But in the implementation, all accordions are full width and only the height changes.

📸 Screenshots or code

Figma:

Screenshot 2024-05-09 at 12 44 24

Implementation:

Screenshot 2024-05-09 at 12 44 56

🧐 Expected behaviour

The accordion sizes should match figma.

📝 Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given a accordion exists When it is small Then it should have a 300px width

Given a accordion exists When it is default Then it should have a 600px width

Given a accordion exists When it is large Then it should have a 800px width

Additional info

Current accordions could be a full width size variant.

MI6-255 commented 5 days ago

Design brought this up to ask why it was moved to design, which I was unsure why. Therefore, I have moved it back to refinement so we can discuss at refinement on if it needs design