mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 23 forks source link

[ic-dialog] Cypress visual regression tests failing #1944

Closed gd2910 closed 3 weeks ago

gd2910 commented 1 month ago

Summary of the bug

fade-in class is applied to element but not receiving the CSS (opacity: 1) which results in the background being lighter and failing all visual regression tests.

DoD includes applying the correct regression thresholds.

This seems to be a Windows only issue.

🪜 How to reproduce

Tell us the steps to reproduce the problem: Run IcDialog Cypress tests and pause when a Dialog is open, inspect the element and see that the opacity is set to 0 on ic-dialog, making the background lighter than it should be and failing the visual regression tests by a very large margin.

📸 Screenshots or code

image image

🖥 📱 Device

🧐 Expected behaviour

Cypress tests should also have the fade-in opacity applied. Visual regression tests should have a threshold below 10%