mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 25 forks source link

1979 ic back to top update icon only variant to match design #1982

Closed GCHQ-Developer-530 closed 3 months ago

GCHQ-Developer-530 commented 3 months ago

Summary of the changes

Update back to top icon variant to match Figma designs and update back to top cypress test and merge in ci generated snapshot. For some reason the ci would only a non blurry image of the back to top when the viewport was set to iphone.

Related issue

1979

Checklist

General

Testing

Accessibility

Resize/zoom behaviour

System modes

Testing content extremes

github-actions[bot] commented 3 months ago

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1979-ic-back-to-top-update-icon-only-variant-to-match-design/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1979-ic-back-to-top-update-icon-only-variant-to-match-design/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1979-ic-back-to-top-update-icon-only-variant-to-match-design/nextjs

github-actions[bot] commented 3 months ago

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1979-ic-back-to-top-update-icon-only-variant-to-match-design/cypress-image-diff-screenshots View the html report here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1979-ic-back-to-top-update-icon-only-variant-to-match-design/cypress-image-diff-html-report

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: GCHQ-Developer-530
:x: github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.