mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 25 forks source link

docs(react): add Hero playground to React #1997

Closed MI6-255 closed 3 months ago

MI6-255 commented 3 months ago

Summary of the changes

add Hero playground to React to test all combinations of props

Related issue

1970

Checklist

General

Testing

Accessibility

Resize/zoom behaviour

System modes

Testing content extremes

github-actions[bot] commented 3 months ago

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-hero/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-hero/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-hero/nextjs

github-actions[bot] commented 3 months ago

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1970-hero/cypress-image-diff-screenshots View the html report here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1970-hero/cypress-image-diff-html-report

ad9242 commented 3 months ago

when setting contentAligned to center, the secondary heading does not center align - is that correct?

image

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

MI6-255 commented 3 months ago

when setting contentAligned to center, the secondary heading does not center align - is that correct?

image

Good spot, I didn't notice this on a bigger screen size, I'll open a ticket for it!

https://github.com/mi6/ic-ui-kit/issues/2040