1970 badge, breadcrumb and card playgrounds

GCHQ-Developer-530 commented 2 weeks ago

Summary of the changes

Storybook playgrounds for badge, breadcrumb and card. Fix for breadcrumbs so that appearance and backBreadcrumbOnly props can be changed after being set.

Ticket created for collapsed prop not working after being set on breadcrumbs - https://github.com/mi6/ic-ui-kit/issues/1998

Related issue

Part of #1970

Checklist

General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.

Accessibility

[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[x] Min/max content examples tested with no loss of content or overflow.
[x] All prop combinations work without issue.
[x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[x] Controlled and uncontrolled input components tested.

github-actions[bot] commented 2 weeks ago

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-component-playgrounds/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-component-playgrounds/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-component-playgrounds/nextjs

github-actions[bot] commented 2 weeks ago

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1970-component-playgrounds/cypress-image-diff-screenshots/diff View the html report here: https://mi6.github.io/ic-ui-kit/branches/1970-component-playgrounds/cypress-image-diff-html-report/cypress-image-diff-html-report.html

GCHQ-Developer-112 commented 1 week ago

There's a bug with breadcrumb group: When you set backBreadcrumbOnly as true and then set it as false, the back arrow stays. It replaces the chevron that should be there

https://github.com/mi6/ic-ui-kit/assets/113986285/1a4a3df5-a850-496e-9b5d-c33f629d010e

GCHQ-Developer-530 commented 1 week ago

There's a bug with breadcrumb group: When you set backBreadcrumbOnly as true and then set it as false, the back arrow stays. It replaces the chevron that should be there

Breadcrumb.group.bug.mov

I will create an issue for this

CLAassistant commented 1 week ago

All committers have signed the CLA.

mi6 / ic-ui-kit