search

mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 25 forks source link

Remove unused link CSS variables #2010

Open GCHQ-Developer-847 opened 3 months ago

GCHQ-Developer-847 commented 3 months ago

Summary

Note: This ticket should be completed after the light and dark link updates.

There are some CSS variables relating to the ic-link which are no longer being used.

💬 Description

The following hyperlink CSS variables are no longer used in any component: --ic-hyperlink-hover --ic-hyperlink-contrast --ic-hyperlink-contrast-hover

At time of writing, the --ic-hyperlink-contrast-visited variable is being used in the ic-link component but the light and dark link updates ticket removes that use, meaning that this variable can also be removed as part of this ticket.

💰 Use value

These variables are not being used so there is no need to keep them, and keeping them may cause confusion for customers.

Additional info

This is a breaking change because some teams / projects may be using the CSS colour variables.

GCHQ-Developer-847 commented 2 months ago

While triaging this ticket, we were wondering whether it would actually be a breaking change...

I think it would be because there is always the possibility someone might be using any of the variables in variables.css as they may come across one of them and think it an appropriate colour to use for a certain use case. And with these link colours ^ , they may not realise that we don't actually use them in the ICDS components any more / at all.

I do actually remember seeing one team use the hover link colour which is why I must have marked this ticket as a breaking change! So yep, this change needs to be added to the v3 branch.

MI6-255 commented 1 month ago

Do as part of: https://github.com/mi6/ic-ui-kit/issues/1214

Points removed from this ticket, was marked as 0.5