MI6-255 commented 2 weeks ago

Summary of the changes

add Page Header playground to React so all props can be tested

Related issue

1970

Checklist

General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.

Accessibility

[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[x] Min/max content examples tested with no loss of content or overflow.
[x] All prop combinations work without issue.
[x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[x] Controlled and uncontrolled input components tested.

CLAassistant commented 2 weeks ago

All committers have signed the CLA.

github-actions[bot] commented 2 weeks ago

Your PR was set to target main, PRs should be target develop The base branch of this PR has been automatically changed to develop, please check that there are no merge conflicts

github-actions[bot] commented 2 weeks ago

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-pageheader/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-pageheader/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-pageheader/nextjs

ad9242 commented 2 weeks ago

do you think it should have some page content, so that it can be scrolled & see the sticky working?

MI6-255 commented 1 week ago