mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 23 forks source link

[ic-search-bar] a11y violations #2015

Open MI6-286 opened 2 weeks ago

MI6-286 commented 2 weeks ago

Summary of the bug

E2E a11y testing on ic-search-bar has shown critical violations. A ticket (#1939) already exists for an aria-allowed-attribute accessibility violation for ic-search-bar/ic-select, but creating more a11y tests for ic-search-bar has revealed further violations: aria-required-attribute and aria-valid-attribute (see below).

šŸŖœ How to reproduce

Uncomment the commented out a11y tests in the ic-search-bar Cypress tests and run tests. See the errors.

To see the aria-required-attribute and aria-valid-attribute errors specifically, run the following tests: "should render search bar with options - no filtering" "should render search bar with custom empty option list text" "should render search bar with characters until suggestion set - no show" "should render search bar with characters until suggestion set - show" "should render search bar with long option labels"

šŸ“ø Screenshots or code

image

šŸ–„ šŸ“± Device

šŸ§ Expected behaviour

All a11y tests should pass. To check this please uncomment the a11y tests in the ic-search-bar Cypress tests.