mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 22 forks source link

Loading indicator should always be the circular variant when at `icon` size #2029

Open GCHQ-Developer-847 opened 1 week ago

GCHQ-Developer-847 commented 1 week ago

Summary of the bug

When the size prop on the loading indicator is set to icon, it should always show the circular variant and never the linear variant (this is the case in the Figma designs).

🪜 How to reproduce

  1. Go to the story for the icon loading indicator and change the type in the DevTools to linear.
  2. See that it tries to render a very small linear loading indicator e.g.:

🧐 Expected behaviour

As defined on Figma, the loading indicator should always display the circular variant when it is set to its icon size.

Additional info

It is probably worth adding a note to the description for the size prop to say that setting it to icon will always display the circular indicator.