mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 22 forks source link

Circular loading indicator stops working when changing between `circular` and `linear` for `type` prop #2030

Open GCHQ-Developer-847 opened 1 week ago

GCHQ-Developer-847 commented 1 week ago

Summary of the bug

The circular variant of the loading indicator stops working when changing between circular and linear for the type prop.

🪜 How to reproduce

  1. Go to one of the props playground stories for the loading indicator.
  2. Change the type prop to linear and back to circular.
  3. See that the loading indicator isn't displaying correctly.

📸 Screenshots or code

The loading indicator becomes a complete circle (and no matter whether it's indeterminate or determinate).

🧐 Expected behaviour

The circular variant should render as normal when changing between types.

Additional info

Need to decide whether this bug actually matters - how likely is it that a developer will want to change the loading indicator type while it's rendered?