mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 22 forks source link

Feature/1970 loading indicator props playground #2031

Closed GCHQ-Developer-847 closed 1 week ago

GCHQ-Developer-847 commented 1 week ago

Summary of the changes

Added web components and React props playgrounds for loading indicator.

Some loading indicator stories already had some playground controls - I have removed these and just added whole new playground stories which have all the props, to reduce duplication.

I had to create separate indeterminate and determinate playgrounds because Storybook was having issues displaying them both in one (it kept changing the progress value to NaN when I set it to null).

Related issue

1970

Created #2029 and #2030 to fix the bugs I noticed when checking different prop combinations.

Checklist

General

Testing

Accessibility

Resize/zoom behaviour

System modes

Testing content extremes

github-actions[bot] commented 1 week ago

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/feature/1970-loading-indicator-props-playground/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/feature/1970-loading-indicator-props-playground/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/feature/1970-loading-indicator-props-playground/nextjs

github-actions[bot] commented 1 week ago

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/feature/1970-loading-indicator-props-playground/cypress-image-diff-screenshots/diff View the html report here: https://mi6.github.io/ic-ui-kit/branches/feature/1970-loading-indicator-props-playground/cypress-image-diff-html-report/cypress-image-diff-html-report.html