mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 22 forks source link

feat(web-components): add large variant to status tag #2034

Open GCHQ-Developer-773 opened 1 week ago

GCHQ-Developer-773 commented 1 week ago

added large variant to status tag and added large to storybook, and included large and large outlined in css for status tags

Summary of the changes

Tell us, in a few words, what the changes are.

Related issue

239

Checklist

General

Testing

Accessibility

Resize/zoom behaviour

System modes

Testing content extremes

CLAassistant commented 1 week ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

github-actions[bot] commented 1 week ago

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/239-ic-status-tag-new-sizes/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/239-ic-status-tag-new-sizes/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/239-ic-status-tag-new-sizes/nextjs

github-actions[bot] commented 1 week ago

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/239-ic-status-tag-new-sizes/cypress-image-diff-screenshots/diff View the html report here: https://mi6.github.io/ic-ui-kit/branches/239-ic-status-tag-new-sizes/cypress-image-diff-html-report/cypress-image-diff-html-report.html

GCHQ-Developer-112 commented 1 week ago

Sorry, just realised that this is a draft PR so you may already be working to address the comments above. Please add a story to the React storybook if you're not already working on this