Open GCHQ-Developer-530 opened 1 week ago
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-more-component-playgrounds/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-more-component-playgrounds/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-more-component-playgrounds/nextjs
seem to be missing some props on link:
hreflang
,rel
,referrerpolicy
,download
. would be good to add them, just to see how they are passed down to the native<a>
tag under the covers
I had considered these, when I added them they didn't change anything visually and especially download seemed like even the prop just being there meant that it was being applied (but I tested it and it seemed to work that way on the native <a>
tag too) so couldn't test href or target if the link is downloaded even when download="false".
Summary of the changes
Add playground story for link and skeleton
Related issue
Part of #1970
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes