mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
19 stars 22 forks source link

test(react): adding cypress visual regression tests for IcStepper #2037

Open MI6-286 opened 1 week ago

MI6-286 commented 1 week ago

Adding cypress visual regression tests for IcStepper.

Summary of the changes

Migrated loki screenshots for IcStepper to Cypress visual regression tests.

Related issue

1891

github-actions[bot] commented 1 week ago

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1891-cypress-visual-regression-tests-stepper/web-components View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1891-cypress-visual-regression-tests-stepper/react View your NextJs branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1891-cypress-visual-regression-tests-stepper/nextjs

github-actions[bot] commented 1 week ago

Cypress visual tests failed. View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/1891-cypress-visual-regression-tests-stepper/cypress-image-diff-screenshots/diff View the html report here: https://mi6.github.io/ic-ui-kit/branches/1891-cypress-visual-regression-tests-stepper/cypress-image-diff-html-report/cypress-image-diff-html-report.html

CLAassistant commented 1 week ago

CLA assistant check
All committers have signed the CLA.

MI6-286 commented 6 days ago

in the ic-stepper.e2e.ts file there is a test that ensures the stepper width does not drop below 100px:

it("should keep the length of the step connect at 100px if a connectorWidth under 100px is given",

it would be good to add this as a cypress test

the e2e file can then be removed too

There's a ticket for the e2e Cypress migration, so this can be done within this ticket - https://github.com/mi6/ic-ui-kit/issues/2051