chore(webpack): improve folder structure

evenstensberg commented 5 days ago

Summary of the changes

Just improving a bit of repo infra

Related issue

N/A

Checklist

General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.
[x] Playground stories in React Storybook up to date, with any prop changes and additions addressed.

Accessibility

[ ] Accessibility Insights FastPass performed.
[ ] A11y unit test added and yields no issues.
[ ] A11y plug-in on Storybook yields no issues.
[ ] Manual screen reader testing performed using NVDA and VoiceOver.
[ ] Manual keyboard testing for keyboard controls and logical focus order.
[ ] Correct roles used and ARIA attributes used correctly where required.
[ ] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[ ] Page can be zoomed to 400% with no loss of content.
[ ] Screen magnifier used with no issues.
[ ] Text resized to 200% with no loss of content.
[ ] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[ ] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[ ] Windows High Contrast mode tested with no loss of content.
[ ] System light and dark mode tested with no loss of content.
[ ] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[ ] Min/max content examples tested with no loss of content or overflow.
[ ] All prop combinations work without issue.
[ ] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[ ] Controlled and uncontrolled input components tested.

CLAassistant commented 5 days ago

All committers have signed the CLA.

github-actions[bot] commented 5 days ago

Your PR was set to target main, PRs should be target develop The base branch of this PR has been automatically changed to develop, please check that there are no merge conflicts

GCHQ-Developer-530 commented 3 days ago

Hi @evenstensberg thank you for your contribution. Our cypress tests seem to be struggling to find webpack with this new folder structure, please could you take another look to see if there's a way they can work with this? Thanks again 😊

evenstensberg commented 3 days ago

@GCHQ-Developer-530 The test suite is running, but there's runtime errors. I think there's something wrong with the configuration still, fixing it later.

evenstensberg commented 2 days ago

@GCHQ-Developer-530 I think it should work now. Could you run locally and verify?

Also, I'm very interested in contributing more to your repositories, and maybe I'm lucky to get some swag :D

If you need help with infrastructure, react or anything related to build tools, I'm happy to help. I've done some work for other organizations that might suit your needs well, such as adding cspell, which is a grammar linter for code.

Let me know what you think :)

GCHQ-Developer-530 commented 2 days ago

@evenstensberg Looks like that's worked, thank you so much! We'd love for you to contribute anything you feel could improve our repo, please feel free to open pull requests and the team will have a look 😊 In relation to swag, I spoke to the team and we should be able to think about it after some more contributions!

GCHQ-Developer-530 commented 2 days ago

Just one comment from me before it should be ready for approval, please could you amend your commits so that there is only one commit per scope e.g. one commit for the react changes, one commit for the fonts changes, and one commit for the canary react changes?

evenstensberg commented 2 days ago

@GCHQ-Developer-530 Great! Before eventually merging, test everything locally first. It is important that the behaviour is correct and sometimes things break with 3rd party webpack usage (most tools are flexible around webpack, but cypress is very verbose).

RE: swag -> My email is evenstensberg@gmail.com, if you need my physical address, send me an email.

The commits are now scoped. In the future when using webpack, the normal convention is putting it in a .webpack folder, and defining context (where webpack should run, its like process.cwd) is used to have identical behaviour as a root webpack.config.js.

Let me know if you have any questions.

mi6 / ic-ui-kit