mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 25 forks source link

[ic-popover-menu]: Clicking a menu item which closes the popover menu doesn't trigger the icPopoverClosed event #2297

Open jd239 opened 2 months ago

jd239 commented 2 months ago

Summary of the bug

When clicking on a menu item which closes ic-popover-menu, the icPopoverClosed event is not triggered. Once the React code snippet has been updated, this event will be used to update state

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to the StackBlitz
  2. Click the top nav button in the top right to display the popover menu
  3. Go one level down and click 'find'
  4. The popover menu should close.
  5. Click the button in the top right again
  6. The popover menu doesn't appear

📸 Screenshots or code

View StackBlitz

🖥 📱 Device

🧐 Expected behaviour

The menu should open

📝 Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given that the popover menu is open When I click the find menu item and then click the top nav button in the top right
Then the popover menu should appear again

Additional info

A console log has been added to icPopoverClosed to demonstrate that the event is not being called.

MI6-255 commented 2 months ago

Complete this issue before: https://github.com/mi6/ic-design-system/issues/1086