search

mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
25 stars 28 forks source link

Internal issue 2907 - Interaction button slot wrong placement #2614

Open ticket-sync[bot] opened 3 weeks ago

ticket-sync[bot] commented 3 weeks ago

When an IcCard is missing a href attribute, the interaction button is no longer positioned correctly:

[ICDS Select (React component) (forked) - StackBlitz|https://stackblitz.com/edit/rc77dn-9vvja3?file=src%2Fapp.tsx,src%2FWorkingCard.tsx,src%2FBrokenCard.tsx]

This behaviour is inconsistent across browsers. In the pictures, the expected behaviour is working in firefox, but in Edge/Chrome/Chromium the interaction button is next to the IcCard header instead of it’s correct slot in the top right

GCHQ-Developer-299 commented 2 weeks ago

While fixing this issue, please add Visual Regression test