mi6 / ic-ui-kit

Intelligence Community UI Kit (based on StencilJS)
MIT License
26 stars 28 forks source link

Extra attributes from the server class,role #2750

Open timja opened 3 weeks ago

timja commented 3 weeks ago

Summary of the bug

This may be something to do with next.js and not belong here but its a pretty annoying error that spams the developer console. image

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. See code below
  2. Refresh the page a few times and look at dev console

📸 Screenshots or code

image

Simplest code that fairly reliably reproduces it, if you remove the SVG it triggers less often but it still triggers

export default function PageInner() {
    return (
        <>
            <IcTopNavigation appTitle={"ICDS"} version="v0.0.7">
                <SlottedSVG
                    slot="app-icon"
                    xmlns="http://www.w3.org/2000/svg"
                    height="24"
                    viewBox="0 0 24 24"
                    width="24"
                    fill="#000000"
                >
                    <path d="M0 0h24v24H0V0z" fill="none" />
                    <path d="M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm0 18c-4.41 0-8-3.59-8-8s3.59-8 8-8 8 3.59 8 8-3.59 8-8 8zm-5.5-2.5l7.51-3.49L17.5 6.5 9.99 9.99 6.5 17.5zm5.5-6.6c.61 0 1.1.49 1.1 1.1s-.49 1.1-1.1 1.1-1.1-.49-1.1-1.1.49-1.1 1.1-1.1z" />
                </SlottedSVG>
                <IcNavigationItem slot="navigation">
                    <Link href={"/"} slot={"navigation-item"}>Get started</Link>
                    <Link href={"/"} slot={"navigation-item"}>Get started2</Link>
                </IcNavigationItem>

            </IcTopNavigation>
        </>
    )
}

🖥 📱 Device

🧐 Expected behaviour

No console error

📝 Acceptance Criteria

If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.

Given When
Then

Additional info

Tell us anything else useful to help us fix or understand the problem.

evenstensberg commented 3 weeks ago

@timja unrelated, but can you test https://github.com/mi6/ic-ui-kit/pull/2617 ?