Propagate flask_rest_jsonapi errors to flask

miLibris / flask-rest-jsonapi

Flask extension to build REST APIs around JSONAPI 1.0 specification.

http://flask-rest-jsonapi.readthedocs.io

MIT License

598 stars 153 forks source link

Propagate flask_rest_jsonapi errors to flask #163

Closed JortdeBokx closed 3 years ago

JortdeBokx commented 5 years ago

When the ROPAGATE_EXCEPTIONS is set, it is desirable to re-throw the error such that any registered flask error handlers will take care of it. This fixes the error described in issue #162.

coveralls commented 5 years ago

Coverage remained the same at 90.772% when pulling 68d0faa8def56517bdce4df5cac13bb94985a97b on JortdeBokx:master into b44bc08b11213d49fadae873650d3555889052ec on miLibris:master.

coveralls commented 5 years ago

Coverage remained the same at 90.772% when pulling 1421fee0dbed8b891b3f9c7fe7342dc6939455e6 on JortdeBokx:master into b44bc08b11213d49fadae873650d3555889052ec on miLibris:master.

nikhaldi commented 5 years ago

I support this change. It gives users the option to fully customize the error handling. Not all users will be happy with the particular error handling that is enforced otherwise.