search

miLibris / flask-rest-jsonapi

Flask extension to build REST APIs around JSONAPI 1.0 specification.
http://flask-rest-jsonapi.readthedocs.io
MIT License
597 stars 153 forks source link

Update marshmallow to 2.18.1 #165

Open ivan-artezio opened 5 years ago

ivan-artezio commented 5 years ago

Marshmallow 2.18.0 raises ChangedInMarshmallow3Warning for nested schemas which is annoying when running tests and clogs the logs. Marshmallow should be updated to 2.18.1 where this issue was fixed. https://marshmallow.readthedocs.io/en/3.0/changelog.html https://github.com/marshmallow-code/marshmallow/pull/1136

multimeric commented 5 years ago

I would say Marshmallow needs to be updated to 3.X

PATolk commented 5 years ago

I needed to upgrade Marshmallow to 3.2.1 and now I get an error File "/lib/python3.6/site-packages/flask_rest_jsonapi/resource.py", line 131, in get result = schema.dump(objects).data AttributeError: 'dict' object has no attribute 'data'

multimeric commented 5 years ago

Yes, the library has to be changed to make it Marshmallow 3 compatible. I've fixed this in my PR: #172. However it hasn't yet been merged.

auvipy commented 3 years ago

this can be closed now