Fix issue #49 - Githubissues

miLibris / flask-rest-jsonapi

Flask extension to build REST APIs around JSONAPI 1.0 specification.

http://flask-rest-jsonapi.readthedocs.io

MIT License

597 stars 153 forks source link

Fix issue #49 #50

Closed sodre closed 7 years ago

sodre commented 7 years ago

[x] Replicate issue #49 using py.test
[x] Propose a fix
[x] Correct tests that would be affected by fix, #51 #52

coveralls commented 7 years ago

Coverage decreased (-0.04%) to 95.0% when pulling 3ae44823163a979b654aaabdfbf93e7752ec264b on sodre:i-49-related-link into 9566f6f9ae371d0e348c8a8804d3b27dcb4dc2c6 on miLibris:master.

sodre commented 7 years ago

This PR is ready for review.

The coverage/coveralls fail should be ignored. It occurs because the proposed fix trades 10-covered-lines of resource.py in favor of one function call to marshmallow-jsonapi get_related_url.

When the prosed fix is applied, two other unit tests begin to fail unless they are corrected before-hand. I split those fixes in PRs #51, and #52, feel free to merge them first or change to order of the commits.

cc: @akira-dev, @jcampbell

sodre commented 7 years ago

@akira-dev

Any chance of taking a look at this PR? The coveralls failure is because the proposed solution reduces the number of lines of code in favor of calling an existing function in marshmallow-jsonapi.

sodre commented 7 years ago

pinging @akira-dev 🏓

akira-dev commented 7 years ago

Thx