search

miRTop / mirtop

command lines tool to annotate miRNAs with a standard mirna/isomir naming
https://mirtop.readthedocs.org
MIT License
18 stars 21 forks source link

print as function for Python 3 transition #46

Closed smoe closed 6 years ago

smoe commented 6 years ago

In analogy to https://github.com/miRTop/mirtop/pull/45 for the dev branch.

codecov[bot] commented 6 years ago

Codecov Report

Merging #46 into dev will increase coverage by 0.05%. The diff coverage is 90.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #46      +/-   ##
==========================================
+ Coverage   76.54%   76.59%   +0.05%     
==========================================
  Files          24       24              
  Lines        2059     2064       +5     
==========================================
+ Hits         1576     1581       +5     
  Misses        483      483
Impacted Files Coverage Δ
test/test_functions.py 88.23% <100%> (+0.04%) :arrow_up:
mirtop/gff/convert.py 89.88% <100%> (+0.11%) :arrow_up:
mirtop/gff/stats.py 72.97% <25%> (+0.37%) :arrow_up:
mirtop/gff/__init__.py 20.33% <33.33%> (+1.37%) :arrow_up:
test/test_automated_analysis.py 89.39% <95%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 979d317...8037004. Read the comment docs.

smoe commented 6 years ago

I should have tried that myself before submitting. The explicit "\n" may (or may not) bring trouble when mixing Windows, Mac and Linux worlds?

I just empirically found out that the information on the end being required that way was either missunderstood on my side or wrong. The default behaviour was just fine. The end="" shall go, this means. I think I apologised before. I do it again: sorry.

You may have seen the https://github.com/miRTop/mirtop/pull/46/commits/80370041fc7846881ae9e3690e6d4fb6edb378fc commit already which removes that nonsense again :o/

lpantano commented 6 years ago

awesome! you don’t need to apologize! thanks for the time you are investing, really appreciate it! I’ll merge it tomorrow when I habe my computer again.