miRTop / mirtop

command lines tool to annotate miRNAs with a standard mirna/isomir naming
https://mirtop.readthedocs.org
MIT License
18 stars 21 forks source link

Python 3 support: use general fixes and six for 2 and 3 support #50

Closed chapmanb closed 5 years ago

chapmanb commented 5 years ago

This makes the code base compatible with Python 3 in a first step towards moving bcbio and dependencies. It uses six and general changes to make it both 2 and 3 compatible and tests pass for me on both. The changes are:

codecov[bot] commented 5 years ago

Codecov Report

Merging #50 into master will increase coverage by 0.01%. The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   76.59%   76.61%   +0.01%     
==========================================
  Files          24       24              
  Lines        2064     2065       +1     
==========================================
+ Hits         1581     1582       +1     
  Misses        483      483
Impacted Files Coverage Δ
mirtop/gff/merge.py 37.77% <0%> (ø) :arrow_up:
mirtop/gff/validator.py 87.83% <100%> (ø) :arrow_up:
mirtop/gff/convert.py 89.88% <100%> (ø) :arrow_up:
mirtop/mirna/realign.py 91.15% <100%> (ø) :arrow_up:
mirtop/importer/srnabench.py 82.31% <100%> (ø) :arrow_up:
mirtop/gff/stats.py 72.97% <100%> (ø) :arrow_up:
mirtop/gff/body.py 87.5% <100%> (ø) :arrow_up:
mirtop/libs/do.py 61.01% <75%> (+0.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c71d53...1f03e41. Read the comment docs.

chapmanb commented 5 years ago

Lorena, thank you for the pointer to the dev branch work. Closing in favor of #51 which is based on that branch.