search

mia-platform / design-system

React graphical components designed by Mia Platform
https://mia-platform.github.io/design-system/
Apache License 2.0
12 stars 1 forks source link

Color icon for Button component even on hover #521

Closed valesceva closed 4 months ago

valesceva commented 4 months ago

The feature or bug you are proposing

Add color to icon added to icon props of Button like the text, it should work even if i pass the icon component

A snippet of code for replicating the issue or showing the proposal usage if applicable

<Button hierarchy='neutral' icon={<Icon name='FiDownload' size={16} />} type={'outlined'} />

fredmaggiowski commented 4 months ago

If you need the Icon to change color during button interactions, like hovering etc, the best approach is to use color="currentColor".

FYI https://github.com/mia-platform/design-system/issues/357 proposes to make currentColor the default behaviour