Can't update antd for broken antd es imports

mia-platform / design-system

React graphical components designed by Mia Platform

https://mia-platform.github.io/design-system/

Apache License 2.0

13 stars 1 forks source link

Can't update antd for broken antd es imports #588

Open fredmaggiowski opened 3 months ago

fredmaggiowski commented 3 months ago

The feature or bug you are proposing

In several components there are antd/es imports that breaks antd update.

Such imports are not part of the public interface and therefore subject to breaking changes, they must not be imported

Here search result: https://github.com/search?q=repo%3Amia-platform%2Fdesign-system%20%27antd%2Fes%2F&type=code

Affected components are

[X] Breadcrumb #590
[X] Menu #630
[ ] Table
[ ] useFeedbackMessage

Danielecina commented 3 months ago

We need to add a new rule in the ts lint to avoid using the import of nested or unexported dependencies. If the library does not export types, we need to open a pr for them or implement a temporary custom type.